KurtYoung commented on a change in pull request #10022:
[FLINK-14135][hive][orc] Introduce orc ColumnarRow reader for hive connector
URL: https://github.com/apache/flink/pull/10022#discussion_r352404215
##########
File path:
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/TableEnvHiveConnectorTest.java
##########
@@ -95,9 +95,9 @@ public void testDefaultPartitionName() throws Exception {
FileSystem fs = defaultPartPath.getFileSystem(hiveConf);
assertTrue(fs.exists(defaultPartPath));
- TableImpl flinkTable = (TableImpl) tableEnv.sqlQuery("select *
from db1.part order by x");
+ TableImpl flinkTable = (TableImpl) tableEnv.sqlQuery("select y,
x from db1.part order by x");
Review comment:
I noticed this test have a `testDifferentFormats` test, how about we
parameterize this test class to these formats, and test all functionalities
based on different formats?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
