Myasuka commented on a change in pull request #10127: [FLINK-14654] Fix the
arguments number mismatching with placeholders in log statements
URL: https://github.com/apache/flink/pull/10127#discussion_r352409671
##########
File path:
flink-end-to-end-tests/flink-connector-gcp-pubsub-emulator-tests/src/test/java/org/apache/flink/streaming/connectors/gcp/pubsub/emulator/GCloudEmulatorManager.java
##########
@@ -207,7 +207,7 @@ private static boolean waitForOkStatus(String label,
String port) {
private static String getPort(Map<String, List<PortBinding>> ports,
String internalTCPPort, String label) {
List<PortBinding> portMappings = ports.get(internalTCPPort +
"/tcp");
if (portMappings == null || portMappings.isEmpty()) {
- LOG.info("| {} Emulator {} --> NOTHING CONNECTED TO
{}", label, internalTCPPort + "/tcp");
+ LOG.info("| {} Emulator --> NOTHING CONNECTED TO
{}/tcp", label, internalTCPPort);
Review comment:
Emm... Maybe another PR changed this line conveniently, could you find that
PR due to the master code still has this error.
Anyway, this PR mainly focus on correcting the argument mismatching and I
should find out all wrong places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
