docete commented on a change in pull request #10357:
[FLINK-14990][Table-Api]Add bit function inncluding bitand bitor bitnot bitxor
URL: https://github.com/apache/flink/pull/10357#discussion_r352411691
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/functions/sql/FlinkSqlOperatorTable.java
##########
@@ -741,6 +741,38 @@ public SqlMonotonicity getMonotonicity(SqlOperatorBinding
call) {
OperandTypes.family(SqlTypeFamily.STRING,
SqlTypeFamily.STRING)),
SqlFunctionCategory.STRING);
+ public static final SqlFunction BITAND = new SqlFunction(
+ "BITAND",
+ SqlKind.OTHER_FUNCTION,
+ ReturnTypes.ARG0,
+ null,
+ OperandTypes.family(SqlTypeFamily.NUMERIC,
SqlTypeFamily.NUMERIC),
Review comment:
In FunctionGenerator, only `INT_TYPES` are supported as the operands, this
`NUMERIC` is a litter bigger?
BTW: should we support different INTs for BITAND? e.g. BITAND(TINYINT,
BIGINT) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
