xintongsong commented on a change in pull request #10330:
[FLINK-14189][runtime] Extend TaskExecutor to support dynamic slot allocation
URL: https://github.com/apache/flink/pull/10330#discussion_r352446502
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotTable.java
##########
@@ -412,7 +441,7 @@ public boolean tryMarkSlotActive(JobID jobId, AllocationID
allocationId) {
public boolean isSlotFree(int index) {
TaskSlot taskSlot = taskSlots.get(index);
- return taskSlot.isFree();
+ return taskSlot == null || taskSlot.isFree();
Review comment:
True, we could consider removing `TaskSlotState#FREE`, but why `ACTIVE`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
