pnowojski commented on a change in pull request #10359: [FLINK-14813][metrics]
Provide `isBackPressured` Task metric
URL: https://github.com/apache/flink/pull/10359#discussion_r352482539
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -351,6 +353,7 @@ public Task(
this.taskManagerConfig =
Preconditions.checkNotNull(taskManagerConfig);
this.metrics = metricGroup;
+ metricGroup.gauge(MetricNames.IS_BACKPRESSURED, new
BackPressureGauge(this));
Review comment:
Oh, OK, I get it now. I don't mind having an integer vs boolean.
What's the reason that you prefer an integer? That it's easier to aggregate
in systems like Grafana?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
