zhijiangW commented on issue #9986: [FLINK-10933][kubernetes] Implement 
KubernetesSessionClusterEntrypoint.
URL: https://github.com/apache/flink/pull/9986#issuecomment-560306091
 
 
   Additional two non-blocking suggestions: 
   1. It is always good to add some unit tests for verifying the new classes.
   2. If we remove the changes in `KubernetesClusterDescriptor.java`, then this 
PR might be merged beforehand. It is up to which PR would be firstly merged.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to