Github user fpompermaier commented on the pull request:
https://github.com/apache/flink/pull/1324#issuecomment-153606566
Do yiu think that this could fix also #2763?
On 4 Nov 2015 02:20, "Till Rohrmann" <[email protected]> wrote:
> The HashPartition did not count properly the number of occupied memory
> segments, because it excluded the memory segments of the BuildSideBuffer.
> That caused the MutableHashTable to fail when trying to spill a partition
> which did not have any overflow segments. This PR fixes the problem by
also
> counting the memory segments of the BuildSideBuffer.
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> https://github.com/apache/flink/pull/1324
> Commit Summary
>
> - [FLINK-2964] [runtime] Fix broken spilling of MutableHashTable
>
> File Changes
>
> - *M*
>
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/HashPartition.java
> <https://github.com/apache/flink/pull/1324/files#diff-0> (8)
> - *M*
>
flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/HashTableTest.java
> <https://github.com/apache/flink/pull/1324/files#diff-1> (124)
>
> Patch Links:
>
> - https://github.com/apache/flink/pull/1324.patch
> - https://github.com/apache/flink/pull/1324.diff
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/flink/pull/1324>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
