KurtYoung commented on a change in pull request #10380:
[FLINK-14662]Distinguish unknown CatalogTableStatistics and zero
URL: https://github.com/apache/flink/pull/10380#discussion_r352557810
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
##########
@@ -1148,10 +1148,10 @@ public void alterTableColumnStatistics(ObjectPath
tablePath, CatalogColumnStatis
*/
private static boolean
compareAndUpdateStatisticsProperties(CatalogTableStatistics statistics,
Map<String, String> parameters) {
Review comment:
Could you separate this method into 2 dedicated methods? It looks unclear to
have a method with mixed functionality.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
