KurtYoung commented on a change in pull request #10210: [FLINK-14800][hive] Introduce parallelism inference for HiveSource URL: https://github.com/apache/flink/pull/10210#discussion_r352950769
########## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java ########## @@ -40,18 +45,28 @@ import org.apache.hadoop.hive.metastore.api.StorageDescriptor; import org.apache.hadoop.mapred.JobConf; import org.apache.thrift.TException; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import java.io.IOException; import java.sql.Date; import java.util.ArrayList; import java.util.Arrays; import java.util.HashMap; import java.util.List; import java.util.Map; +import static org.apache.flink.connectors.hive.HiveOptions.TABLE_EXEC_HIVE_INFER_SOURCE_PARALLELISM; Review comment: If possible, I would like to avoid `import static`, it makes reader unclear when reading codes, questions like "why this function will be here in this class" come to mind from time to time. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
