zhijiangW commented on a change in pull request #9985: [FLINK-10968][kubernetes] Implement TaskManager Entrypoint for Kubernetes. URL: https://github.com/apache/flink/pull/9985#discussion_r352972835
########## File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnTaskExecutorRunner.java ########## @@ -97,22 +91,7 @@ private static void run(String[] args) { final String currDir = ENV.get(Environment.PWD.key()); LOG.info("Current working Directory: {}", currDir); - // Some dynamic properties for task manager are added to args, such as managed memory size. - final CommandLineParser<ClusterConfiguration> commandLineParser = - new CommandLineParser<>(new ClusterConfigurationParserFactory()); - - ClusterConfiguration clusterConfiguration = null; - try { - clusterConfiguration = commandLineParser.parse(args); - } catch (FlinkParseException e) { - LOG.error("Could not parse command line arguments {}.", args, e); - commandLineParser.printHelp(YarnTaskExecutorRunner.class.getSimpleName()); - System.exit(1); Review comment: It seems we changed the behavior here. The `System.exit(1)` is replaced by throwing exception after reusing `TaskManagerRunner.loadConfiguration` below. Another option is catching `TaskManagerRunner.loadConfiguration` to exit as previous way. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services