azagrebin commented on issue #10161: [FLINK-13986][runtime] Clean up legacy 
code for FLIP-49.
URL: https://github.com/apache/flink/pull/10161#issuecomment-561057717
 
 
   Actually, I did not notice that we do not snapshot the env vars before the 
test and restore them afterwards, like we do e.g. in `PluginConfigTest`:
   ```
           private static Map<String, String> oldEnvVariables;
        
           @Before
        public static void setup() {
                oldEnvVariables = System.getenv();
        }
   
        @After
        public void teardown() {
                if (oldEnvVariables != null) {
                        CommonTestUtils.setEnv(oldEnvVariables, true);
                }
        }
   ```
   This is a cleaner approach.
   Could you add this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to