[
https://issues.apache.org/jira/browse/FLINK-14566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16986766#comment-16986766
]
Andrey Zagrebin edited comment on FLINK-14566 at 12/3/19 10:00 AM:
-------------------------------------------------------------------
[~zhuzh]
I think you are right it raises a lot of questions and would need more time to
understand.
Now I tend to agree with the previous suggestion to expose method for
{{Transformation}}/{{StreamNode}} to set weights for managed memory. We should
just carefully handle the case of already set known spec and then trying to set
the weight for managed memory. I think we should not allow mixing weight and
known spec. Also, I would not touch ResourceSpec now and keep the weight in
{{Transformation}}/{{StreamNode.}}
If we decide to add WeightedResourceSpec later we can adjust internally the
weight setting methods and ResourceSpec accordingly.
was (Author: azagrebin):
[~zhuzh]
I think you are right it raises a lot of questions and would need more time to
understand.
Now I tend to agree with the previous suggestion to expose method for
{{Transformation}}/{{StreamNode}} to set weights for managed memory. We should
just carefully handle the case of already set known spec and then trying to set
the weight for managed memory. I think we should not allow mixing weight and
known spec.
If we decide to add WeightedResourceSpec later we can adjust the weight setting
methods accordingly.
> Enable ResourceSpec to get/set whether managed memory is used
> -------------------------------------------------------------
>
> Key: FLINK-14566
> URL: https://issues.apache.org/jira/browse/FLINK-14566
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / Coordination
> Affects Versions: 1.10.0
> Reporter: Zhu Zhu
> Priority: Critical
> Fix For: 1.10.0
>
>
> To calculate managed memory fraction for an operator with UNKNOWN resources,
> we need to know whether the operator will use managed memory, according to
> FLINK-14062.
> To achieve this, we need an interface to set/get whether an operator uses
> managed memory. It can be part of {{ResourceSpec}} or directly locates in the
> operator description classes ({{Transformation}}/{{StreamNode}}).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
