tillrohrmann commented on a change in pull request #10143: 
[FLINK-13184]Starting a TaskExecutor blocks the YarnResourceManager's main 
thread
URL: https://github.com/apache/flink/pull/10143#discussion_r353108217
 
 

 ##########
 File path: 
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
 ##########
 @@ -407,15 +404,9 @@ private void startTaskExecutorInContainer(Container 
container) {
                                containerIdStr,
                                container.getNodeId().getHost());
 
-                       nodeManagerClient.startContainer(container, 
taskExecutorLaunchContext);
+                       nodeManagerClient.startContainerAsync(container, 
taskExecutorLaunchContext);
 
 Review comment:
   I think this call no longer needs to be in the try catch block.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to