TisonKun commented on a change in pull request #10392: [FLINK-14854][client]
Add executeAsync() method to execution environments
URL: https://github.com/apache/flink/pull/10392#discussion_r353128930
##########
File path:
flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java
##########
@@ -812,18 +854,16 @@ public JobExecutionResult execute(String jobName) throws
Exception {
final Plan plan = createProgramPlan(jobName);
final ExecutorFactory executorFactory =
-
executorServiceLoader.getExecutorFactory(configuration);
-
- final Executor executor =
executorFactory.getExecutor(configuration);
+ executorServiceLoader.getExecutorFactory(configuration);
- try (final JobClient jobClient = executor.execute(plan,
configuration).get()) {
+ checkNotNull(
Review comment:
Yes correct. I just noticed that we check not null for
`configuration.get(DeploymentOptions.TARGET)` so that env that doesn't set
`DeploymentOptions.TARGET` will fail already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
