wuchong opened a new pull request #10403: [FLINK-14645][table] Support to keep 
nullability and precision when converting DataTypes to properties
URL: https://github.com/apache/flink/pull/10403
 
 
   
   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that 
you want to help us improve Flink. To help the community review your 
contribution in the best possible way, please go through the checklist below, 
which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a 
hassle. In order to uphold a high standard of quality for code contributions, 
while at the same time managing a large number of contributions, we need 
contributors to prepare the contributions well, and give reviewers enough 
contextual information for the review. Please also understand that 
contributions that do not follow this guide will take longer to review and thus 
typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA 
issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are 
made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the 
pull request", where *FLINK-XXXX* should be replaced by the actual issue 
number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following 
this pattern: `[hotfix] [docs] Fix typo in event time introduction` or 
`[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the 
pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean 
verify` passes. You can set up Travis CI to do that following [this 
guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
   
     - Each pull request should address only one issue, not mix up code from 
multiple issues.
     
     - Each commit in the pull request has a meaningful commit message 
(including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and 
this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   Use the `LogicalType#asSerializableString` as the properties value string 
instead of using `TypeStringUtil`. This can keep the nullability and precision.
   
   NOTE: However, this will lead to the default conversion class of `TIMESTAMP` 
declared in DDL will be `LocalDateTime`. In the previous versions, the default 
conversion class is `java.sql.Timestamp`. We have to update all the connectors 
to adapt this changes, otherwise it will fail to create the connector. We 
should also add this into release note. 
   
   ## Brief change log
   
   
   82bae84e63e8e42447e75e097a32cc4f8d4f0618
    - Support to parse LegacyTypeInformationType, because user may pass in 
Types.BIG_DEC into TableSchema
   423400c30bcf6a2c0f97d439db1e25fd76f7e01c
    - Use LogicalType.asSerializableString as the data type properties value 
string
   f1f08640eca5f6980b51ecfecd318f36d3f6773e 
b3962df2b64140b0be9232449e93a213404e6ebb 
fb7f5e6fd44afb5c26c72ee579b4eb883b2dccfe 
d7ecec4f1d9e2857f461f82faee5a902224ccd0a 
e80446be9909bd9bcf1304aa0050c87c0bb37479 
ab3e19f2ceea1cb1e60586b9781254609ab2b192
    - update connectors to adapt the properties changes, because the default 
TIMESTAMP conversion class is LocalDateTime now.
   ac84bc121839537b858ed201c464d836f823c209
    - Use `data-type` as watermark expression type key too
   038052c833940fbaef3111ed92525216f13edee2
    - Support to pass nullability and precision defined in DDL to planner
   
   
   ## Verifying this change
   
   This change is already covered by existing tests and new added tests.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to