pnowojski commented on a change in pull request #10375: [FLINK-14845][runtime]
Introduce data compression to reduce disk and network IO of shuffle.
URL: https://github.com/apache/flink/pull/10375#discussion_r352560829
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
##########
@@ -534,6 +543,15 @@ private BufferOrEvent transformToBufferOrEvent(
boolean moreAvailable,
InputChannel currentChannel) throws IOException,
InterruptedException {
if (buffer.isBuffer()) {
+ if (buffer.isCompressed()) {
Review comment:
nit: please split into a smaller methods: `transformToBuffer`,
`transformToEvent`, `decompressBuffer`
```
transformToBufferOrEvent
-> transformToBuffer
if (buffer.isCompressed()) -> decompressBuffer
-> transformToEvent
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
