bowenli86 commented on a change in pull request #10401: [FLINK-15020][hive]
Support timestamp type in hive
URL: https://github.com/apache/flink/pull/10401#discussion_r353350900
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/conversion/HiveInspectors.java
##########
@@ -244,7 +247,11 @@ public static Object toFlinkObject(ObjectInspector
inspector, Object data) {
inspector instanceof
BinaryObjectInspector) {
PrimitiveObjectInspector poi =
(PrimitiveObjectInspector) inspector;
- return poi.getPrimitiveJavaObject(data);
+ Object javaObject =
poi.getPrimitiveJavaObject(data);
+ if (inspector instanceof
TimestampObjectInspector) {
Review comment:
shall we move `inspector instanceof TimestampObjectInspector` to its own
else-if? rather than doing it twice here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
