[ 
https://issues.apache.org/jira/browse/FLINK-14960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987201#comment-16987201
 ] 

Dawid Wysakowicz commented on FLINK-14960:
------------------------------------------

I think we can add it to the whitelist in {{checkCodeDependencies}} method. 
This method checks that we do not use unwanted classes. 
There is a second method {{checkAllowedPackages}} that checks actual classes in 
the packaged jar. We should not add an exclusion there.

[~sewen] As Jark said this code usage comes from the {{flink-core}}, which does 
not relocate this package. The {{flink-core}} is in a {{provided}} scope. We 
did not add any new dependencies. I think it is safe to add that exclusion.
We should probably though add a note to the {{DummyStreamExecutionEnvironment}} 
to remove that check back when we decide to remove it.

> Dependency shading of table modules test fails on Travis
> --------------------------------------------------------
>
>                 Key: FLINK-14960
>                 URL: https://issues.apache.org/jira/browse/FLINK-14960
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / Planner, Tests
>    Affects Versions: 1.10.0, 1.9.1
>            Reporter: Caizhi Weng
>            Priority: Blocker
>              Labels: test-stability
>             Fix For: 1.10.0, 1.9.2
>
>
> e2e - misc cron job fails on Travis. The messages are as follows:
> {code}
> ==============================================================================
> Running 'Dependency shading of table modules test'
> ==============================================================================
> TEST_DATA_DIR: 
> /home/travis/build/apache/flink/flink-end-to-end-tests/test-scripts/temp-test-directory-41270732894
> Flink dist directory: 
> /home/travis/build/apache/flink/flink-dist/target/flink-1.10-SNAPSHOT-bin/flink-1.10-SNAPSHOT
> Success: There are no unwanted dependencies in the 
> /home/travis/build/apache/flink/flink-end-to-end-tests/../flink-table/flink-table-api-java/target/flink-table-api-java-1.10-SNAPSHOT.jar
>  jar.
> Success: There are no unwanted dependencies in the 
> /home/travis/build/apache/flink/flink-end-to-end-tests/../flink-table/flink-table-api-scala/target/flink-table-api-scala_2.11-1.10-SNAPSHOT.jar
>  jar.
> Success: There are no unwanted dependencies in the 
> /home/travis/build/apache/flink/flink-end-to-end-tests/../flink-table/flink-table-api-java-bridge/target/flink-table-api-java-bridge_2.11-1.10-SNAPSHOT.jar
>  jar.
> Success: There are no unwanted dependencies in the 
> /home/travis/build/apache/flink/flink-end-to-end-tests/../flink-table/flink-table-api-scala-bridge/target/flink-table-api-scala-bridge_2.11-1.10-SNAPSHOT.jar
>  jar.
> Success: There are no unwanted dependencies in the 
> /home/travis/build/apache/flink/flink-end-to-end-tests/../flink-table/flink-table-planner/target/flink-table-planner_2.11-1.10-SNAPSHOT.jar
>  jar.
> Failure: There are unwanted dependencies in the 
> /home/travis/build/apache/flink/flink-end-to-end-tests/../flink-table/flink-table-planner-blink/target/flink-table-planner-blink_2.11-1.10-SNAPSHOT.jar
>  jar:       -> com.esotericsoftware.kryo                          not found
> [FAIL] Test script contains errors.
> Checking for errors...
> No errors in log files.
> Checking for exceptions...
> No exceptions in log files.
> Checking for non-empty .out files...
> grep: 
> /home/travis/build/apache/flink/flink-dist/target/flink-1.10-SNAPSHOT-bin/flink-1.10-SNAPSHOT/log/*.out:
>  No such file or directory
> No non-empty .out files.
> [FAIL] 'Dependency shading of table modules test' failed after 0 minutes and 
> 30 seconds! Test exited with exit code 1
> {code}
> See https://api.travis-ci.org/v3/job/617187809/log.txt for full message



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to