xuefuz commented on a change in pull request #10401: [FLINK-15020][hive]
Support timestamp type in hive
URL: https://github.com/apache/flink/pull/10401#discussion_r353365472
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveTypeUtil.java
##########
@@ -274,6 +274,9 @@ public TypeInfo visit(DateType dateType) {
@Override
public TypeInfo visit(TimestampType timestampType) {
+ if (timestampType.getPrecision() != 9) {
Review comment:
I'm wondering if this is too restrictive. While Hive only supports a
precision of 9, it should be able to handle any ts type with a precision less
than 9. Thus, Hive timestamp needs to be mapped to Flink ts(9) while any
ts(<=9) from Flink can be mapped to Hive timestamp. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
