bowenli86 commented on a change in pull request #10388: [FLINK-14912][Table]
create, drop catalog functions through catalog manager
URL: https://github.com/apache/flink/pull/10388#discussion_r353454567
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
##########
@@ -474,13 +478,23 @@ public void sqlUpdate(String stmt) {
catalogManager.dropTable(
dropTableOperation.getTableIdentifier(),
dropTableOperation.isIfExists());
+ } else if (operation instanceof CreateFunctionOperation) {
+ CreateFunctionOperation createFunctionOperation =
(CreateFunctionOperation) operation;
+ createCatalogFunction(createFunctionOperation);
+ } else if (operation instanceof AlterFunctionOperation) {
+ AlterFunctionOperation alterFunctionOperation =
(AlterFunctionOperation) operation;
+ alterCatalogFunction(alterFunctionOperation);
+ } else if (operation instanceof DropFunctionOperation) {
+ DropFunctionOperation dropFunctionOperation =
(DropFunctionOperation) operation;
+ dropCatalogFunction(dropFunctionOperation);
} else if (operation instanceof UseCatalogOperation) {
- UseCatalogOperation useCatalogOperation =
(UseCatalogOperation) operation;
-
catalogManager.setCurrentCatalog(useCatalogOperation.getCatalogName());
+ UseCatalogOperation useCatalogOperation =
(UseCatalogOperation) operation;
Review comment:
revert?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
