JingsongLi commented on a change in pull request #10371: [FLINK-14953][formats] 
use table type to build parquet FilterPredicate
URL: https://github.com/apache/flink/pull/10371#discussion_r353521463
 
 

 ##########
 File path: 
flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/ParquetTableSource.java
 ##########
 @@ -200,6 +204,8 @@ private ParquetTableSource(String path, MessageType 
parquetSchema, Configuration
                        for (FilterPredicate converted : 
convertedPredicates.subList(1, convertedPredicates.size())) {
                                parquetPredicate = 
FilterApi.and(parquetPredicate, converted);
                        }
+                       parquetPredicate = 
LogicalInverseRewriter.rewrite(parquetPredicate);
+                       SchemaCompatibilityValidator.validate(parquetPredicate, 
parquetSchema);
 
 Review comment:
   Why we need rewrite and validate?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to