[ 
https://issues.apache.org/jira/browse/FLINK-15038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16987577#comment-16987577
 ] 

Jark Wu commented on FLINK-15038:
---------------------------------

I think maybe the sql connectors should also be adapted, because most of them 
are using TableSchema#toRowType as the return type of source/sink.
If we change the default conversion class, the #toRowType is also changed. 

> Get field DataType of TableSchema should return DataType with default 
> conversion class
> --------------------------------------------------------------------------------------
>
>                 Key: FLINK-15038
>                 URL: https://issues.apache.org/jira/browse/FLINK-15038
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / API
>            Reporter: Jingsong Lee
>            Assignee: Jingsong Lee
>            Priority: Major
>
> Now, the user and planner construct TableSchema with various DataTypes, them 
> maybe have various conversion classes.
> For example, return DataType of Functions maybe with various TypeInformations 
> and lead to various conversion classes.
> TableSchema should only have logical informations instead of various 
> conversion classes.
> This ticket want to clean the field DataType in TableSchema and return a 
> consistent conversion classes to users.
> Modify:
> getFieldDataTypes/getFieldDataType/toRowDataType in TableSchema.
> Before return, we can bridgeTo default conversion class using 
> TypeConversions.fromLogicalToDataType(type.getLogicalType()).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to