TisonKun edited a comment on issue #10408: [FLINK-14992][client] Add job 
listener to execution environments
URL: https://github.com/apache/flink/pull/10408#issuecomment-561507505
 
 
   @zjffdu I implement `JobListener#onJobExecuted` called back on both 
execution(attach/detached). One more concern is about the thread. In the 
implementation I call callbacks all on `CompletableFuture`'s default thread 
pool(mostly `ForkJoinPool`). It'd be better to check such decision with your 
user case. My concern is that user possibly calls expensive method in callback. 
If we set it as a constraint, it also makes sense we directly call callbacks on 
current thread.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to