WeiZhong94 commented on a change in pull request #10086: [FLINK-14584][python]
Support complex data types in Python user-defined functions
URL: https://github.com/apache/flink/pull/10086#discussion_r353019073
##########
File path: flink-python/pyflink/fn_execution/coder_impl.py
##########
@@ -79,6 +80,101 @@ def __repr__(self):
return 'RowCoderImpl[%s]' % ', '.join(str(c) for c in
self._field_coders)
+class ArrayCoderImpl(StreamCoderImpl):
+
+ def __init__(self, elem_coder):
+ self._elem_coder = elem_coder
+
+ def encode_to_stream(self, value, out_stream, nested):
+ out_stream.write_bigendian_int32(len(value))
+ for elem in value:
+ if elem is None:
+ out_stream.write_byte(False)
+ else:
+ out_stream.write_byte(True)
+ self._elem_coder.encode_to_stream(elem, out_stream, nested)
+
+ def decode_from_stream(self, in_stream, nested):
+ size = in_stream.read_bigendian_int32()
+ elements = [self._elem_coder.decode_from_stream(in_stream, nested)
+ if not not in_stream.read_byte() else None for _ in
range(size)]
+ return elements
+
+ def __repr__(self):
+ return 'ArrayCoderImpl[%s]' % str(self._elem_coder)
+
+
+class MapCoderImpl(StreamCoderImpl):
+
+ def __init__(self, key_coder, value_coder):
+ self._key_coder = key_coder
+ self._value_coder = value_coder
+
+ def encode_to_stream(self, map_value, out_stream, nested):
+ out_stream.write_bigendian_int32(len(map_value))
+ for key in map_value:
+ self._key_coder.encode_to_stream(key, out_stream, nested)
+ value = map_value[key]
+ if value is None:
+ out_stream.write_byte(True)
+ else:
+ out_stream.write_byte(False)
+ self._value_coder.encode_to_stream(map_value[key], out_stream,
nested)
+
+ def decode_from_stream(self, in_stream, nested):
+ size = in_stream.read_bigendian_int32()
+ map_value = {}
+ for _ in range(size):
+ key = self._key_coder.decode_from_stream(in_stream, nested)
+ is_null = not not in_stream.read_byte()
+ if is_null:
Review comment:
use in_stream.read_byte() directly or bool(in_stream.read_byte())?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
