KurtYoung commented on a change in pull request #10316:
[FLINK-14624][table-blink] Support computed column as rowtime attribute
URL: https://github.com/apache/flink/pull/10316#discussion_r353628038
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamExecTableSourceScan.scala
##########
@@ -157,90 +153,32 @@ class StreamExecTableSourceScan(
val ingestedTable = new DataStream(planner.getExecEnv,
streamTransformation)
- val withWatermarks = if (tableSourceTable.watermarkSpec.isDefined) {
- // generate watermarks for rowtime indicator from WatermarkSpec
- val rowType = tableSourceTable.getRowType
- val converter =
planner.createFlinkPlanner.createSqlExprToRexConverter(rowType)
- applyWatermarkByWatermarkSpec(
- config,
- ingestedTable,
- FlinkTypeFactory.toLogicalRowType(rowType),
- tableSourceTable.watermarkSpec.get,
- converter)
- } else {
- val rowtimeDesc: Option[RowtimeAttributeDescriptor] =
- TableSourceUtil.getRowtimeAttributeDescriptor(tableSource,
tableSourceTable.getRowType)
-
- // generate watermarks for rowtime indicator from
DefinedRowtimeAttributes
- if (rowtimeDesc.isDefined) {
- applyWatermarkByRowtimeAttributeDescriptor(
- ingestedTable,
- rowtimeDesc.get,
- producedDataType)
- } else {
- // No need to generate watermarks if no rowtime attribute is specified.
- ingestedTable
+ // generate watermarks for rowtime indicator
+ val rowtimeDesc: Option[RowtimeAttributeDescriptor] =
+ TableSourceUtil.getRowtimeAttributeDescriptor(tableSource,
tableSourceTable.getRowType)
+
+ val withWatermarks = if (rowtimeDesc.isDefined) {
Review comment:
use match to simplify this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
