docete opened a new pull request #10418: [FLINK-15050][table-planner-blink] DataFormatConverters should suppor… URL: https://github.com/apache/flink/pull/10418 …t any TIMESTAMP WITHOUT TIME ZONE types ## What is the purpose of the change User may pass any TIMESTAMP WITHOUT TIME ZONE in, e.g.: `DataTypes.TIMESTAMP(9).bridgedTo(LocalDateTime.class)`, `DataTypes.TIMESTAMP(9).bridgedTo(Timestamp.class)`, `DataTypes.TIMESTAMP(3)`, ``` new AtomicDataType( new LegacyTypeInformationType<>( LogicalTypeRoot.TIMESTAMP_WITHOUT_TIME_ZONE, SqlTimeTypeInfo.TIMESTAMP)) ```, ``` new AtomicDataType( new LegacyTypeInformationType<>( LogicalTypeRoot.TIMESTAMP_WITHOUT_TIME_ZONE, new LegacyTimestampTypeInfo(7))) ``` In such situations, we should return proper converters. ## Brief change log - Let DataFormatConverters support any TIMESTAMP_WITHOUT_TIME_ZONE types - Add tests to verify ## Verifying this change This change is already covered by existing tests, such as *DataFormatConvertersTest)*. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (**yes** / no) - If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
