carp84 commented on a change in pull request #10416: [FLINK-14484] Enable to
control memory usage of RocksDB via Cache and WriteBufferManager
URL: https://github.com/apache/flink/pull/10416#discussion_r353783562
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBOptions.java
##########
@@ -86,4 +86,24 @@
"The default options factory is %s, and it
would read the configured options which provided in
'RocksDBConfigurableOptions'.",
DefaultConfigurableOptionsFactory.class.getName()));
+ public static final ConfigOption<String> BOUNDED_MEMORY_SIZE =
ConfigOptions
+ .key("state.backend.rocksdb.per-slot.total.memory")
+ .stringType()
+ .noDefaultValue()
+ .withDescription("The total memory size shared among all
RocksDB instances per slot. " +
+ "This option has no default value which means no
bounded memory limit.");
+
+ public static final ConfigOption<Double> WRITE_BUFFER_RATIO =
ConfigOptions
+ .key("state.backend.rocksdb.write-buffer.ratio")
+ .doubleType()
+ .defaultValue(0.8)
Review comment:
Why do we set this default value to `0.8`? Maybe `0.5` (read:write=1:1) is a
better idea?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
