pnowojski commented on a change in pull request #10345: [FLINK-12484][runtime]
synchronize all mailbox actions
URL: https://github.com/apache/flink/pull/10345#discussion_r353809709
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/MailboxProcessor.java
##########
@@ -84,16 +83,30 @@
private final StreamTaskActionExecutor actionExecutor;
public MailboxProcessor(MailboxDefaultAction mailboxDefaultAction) {
- this(mailboxDefaultAction, new
TaskMailboxImpl(Thread.currentThread()), StreamTaskActionExecutor.IMMEDIATE);
+ this(mailboxDefaultAction, StreamTaskActionExecutor.IMMEDIATE);
}
- public MailboxProcessor(MailboxDefaultAction mailboxDefaultAction,
TaskMailbox mailbox, StreamTaskActionExecutor actionExecutor) {
+ public MailboxProcessor(MailboxDefaultAction mailboxDefaultAction,
Review comment:
nit: those constructors have a [formatting issue ](**url**)
- Break the argument list or chain of calls if the line exceeds limit or
earlier if you believe that the breaking would improve the code readability
- If you break the line then each argument/call should have a separate line,
including the first one
- Each new line should have one extra indentation (or two for a function
declaration) relative to the line of the parent function name or the called
entity
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
