tillrohrmann commented on a change in pull request #10361: [FLINK-14795][tests]
Rework TaskExecutorPartitionLifecycleTest
URL: https://github.com/apache/flink/pull/10361#discussion_r353880422
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorPartitionLifecycleTest.java
##########
@@ -206,8 +196,7 @@ private void
testJobMasterConnectionTerminationAfterExternalReleaseOrPromotion(T
// once this returns we know that the TE has exited
releasePartitions and associated connection checks
runInTaskExecutorThreadAndWait(taskExecutor, () ->
assertTrue(jobManagerTable.contains(jobId)));
- final CompletableFuture<Collection<ResultPartitionID>>
secondReleasePartitionsCallFuture = new CompletableFuture<>();
- runInTaskExecutorThreadAndWait(taskExecutor, () ->
shuffleEnvironment.releasePartitionsLocallyFuture =
secondReleasePartitionsCallFuture);
+ runInTaskExecutorThreadAndWait(taskExecutor, () ->
partitionTracker.setIsTrackingPartitionsForFunction(jobId -> false));
Review comment:
Instead of updating the `isTrackingPartitionsForFunction` one could also
define/set a function in the beginning which returns an `AtomicBoolean` which
one could use to trigger the behaviour change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
