JingsongLi commented on a change in pull request #10396:
[FLINK-14063][table-planner-blink] Operators use fractions to decide how many
managed memory to allocate
URL: https://github.com/apache/flink/pull/10396#discussion_r354102822
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/join/SortMergeJoinOperator.java
##########
@@ -98,32 +97,15 @@
private transient BaseRow rightNullRow;
private transient JoinedRow joinedRow;
- @VisibleForTesting
public SortMergeJoinOperator(
- long reservedSortMemory, long externalBufferMemory,
FlinkJoinType type, boolean leftIsSmaller,
+ double leftMemRatio, long externalBufferMemory,
FlinkJoinType type, boolean leftIsSmaller,
Review comment:
OK, let's remove legacy codes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
