xuefuz commented on a change in pull request #10426: [FLINK-15062][orc] Orc
reader should use java.sql.Timestamp to read for respecting time zone
URL: https://github.com/apache/flink/pull/10426#discussion_r354105879
##########
File path:
flink-formats/flink-orc/src/test/java/org/apache/flink/orc/OrcColumnarRowSplitReaderTest.java
##########
@@ -283,8 +284,12 @@ public void testReadFileWithTypes() throws IOException {
for (int i = 0; i < rowSize - 1; i++) {
col0.vector[i] = i;
col1.vector[i] = i;
- col2.time[i] = i * 1000;
- col2.nanos[i] = i;
+
+ Timestamp timestamp = Timestamp.valueOf(
+ padZero(4, i + 1000) + "-01-01
00:00:00." + i);
Review comment:
The test would cover more cases if the values are more representative
(rather than a lot of zeros for parts of the timestamp).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
