[
https://issues.apache.org/jira/browse/FLINK-15063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988447#comment-16988447
]
lining edited comment on FLINK-15063 at 12/5/19 5:23 AM:
---------------------------------------------------------
[~azagrebin], in FLINK-12555 you added
[code|https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NettyShuffleEnvironment.java#L181-L182],
here input the wrong metric group. Which define in
[code|https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ShuffleIOOwnerContext.java#L33-L34],
first output, then input. I created pull request for it, could you assign it
to me and review it？
was (Author: lining):
[~azagrebin], in FLINK-12555 you added
[code|https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NettyShuffleEnvironment.java#L181-L182],
here input the wrong metric group. Which define in
[code|https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ShuffleIOOwnerContext.java#L33-L34],
first output, then input. I create PR for it, could you assign it to me and
review it？
> input group and output group of the task metric are reversed
> ------------------------------------------------------------
>
> Key: FLINK-15063
> URL: https://issues.apache.org/jira/browse/FLINK-15063
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Metrics, Runtime / Network
> Reporter: lining
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In
> [code|https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NettyShuffleEnvironment.java#L181-L182],
> the input group and output group of the task metric are reversed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
