JingsongLi commented on a change in pull request #10315: [FLINK-14552][table]
Enable partition statistics in blink planner
URL: https://github.com/apache/flink/pull/10315#discussion_r354125689
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/schema/TableSourceTable.scala
##########
@@ -50,7 +53,8 @@ class TableSourceTable[T](
statistic: FlinkStatistic,
val tableSource: TableSource[T],
val isStreamingMode: Boolean,
- val catalogTable: CatalogTable)
+ val catalogTable: CatalogTable,
+ val tableIdentifier: Option[ObjectIdentifier])
Review comment:
Use `names` is quite hack:
```
if (names.size() == 3) {
// it has ObjectIdentifier
return ObjectIdentifier.of(names.get(0), names.get(1), names.get(2));
} else {
// there is no ObjectIdentifier.
}
```
So I think in future, we should use ObjectIdentifier always instead of names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
