TisonKun commented on a change in pull request #10408: [FLINK-14992][client]
Add job listener to execution environments
URL: https://github.com/apache/flink/pull/10408#discussion_r354200321
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/program/MiniClusterClient.java
##########
@@ -58,6 +58,11 @@ public MiniClusterClient(@Nonnull Configuration
configuration, @Nonnull MiniClus
this.miniCluster = miniCluster;
}
+ @Override
+ public ClusterClient<MiniClusterId> duplicate() {
Review comment:
We can do that. It happens we can share the same instance of
`MiniClusterClient` without worry about lifecycle management since they take no
resource. But a new `MiniClusterClient` is more semantically proper.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
