jinglining commented on a change in pull request #10364: [FLINK-14993][metrics]
FrontMetricGroup passes reporter-specific parameters
URL: https://github.com/apache/flink/pull/10364#discussion_r354226088
##########
File path:
flink-metrics/flink-metrics-jmx/src/test/java/org/apache/flink/metrics/jmx/JMXReporterTest.java
##########
@@ -128,8 +129,12 @@ public Integer getValue() {
}
};
- rep1.notifyOfAddedMetric(g1, "rep1", new FrontMetricGroup<>(0,
new TaskManagerMetricGroup(reg, "host", "tm")));
- rep2.notifyOfAddedMetric(g2, "rep2", new FrontMetricGroup<>(0,
new TaskManagerMetricGroup(reg, "host", "tm")));
+ rep1.notifyOfAddedMetric(g1, "rep1", new FrontMetricGroup<>(
+ new ReporterScopedSettings(0, '.'),
+ new TaskManagerMetricGroup(reg, "host", "tm")));
+ rep2.notifyOfAddedMetric(g2, "rep2", new FrontMetricGroup<>(
+ new ReporterScopedSettings(0, '.'),
Review comment:
As repo2 is different repo, here maybe use 1 is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
