klion26 commented on issue #10344: [FLINK-14264][StateBackend][Rest] Expose state backend in checkpoint rest api URL: https://github.com/apache/flink/pull/10344#issuecomment-562087464 Currently, we use [`jobGraph.getCheckpointingSettings() == null`](https://github.com/apache/flink/blob/b8f3b39abe7213c7523add591e26d74113d2001b/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraphBuilder.java#L236) to test whether enabled Checkpoint, but when generating JobGraph in client-side, we'll always set checkpointSettings, so we'll always create `CheckpointCoordinator` whether or not enable checkpoint. I think we can create another issue to use `jobGraph.isCheckpointingEnabled()` instead of `jobGraph.getCheckpointingSettings() == null` to test whethe enable checkpoint or not, so we can init `stateBackendName` with `null` here, because we'll always fail if checkpoint is disabled, and wil never call `getStateName`. what do you about this? @zentol
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
