zjffdu commented on issue #10408: [FLINK-14992][client] Add job listener to execution environments URL: https://github.com/apache/flink/pull/10408#issuecomment-562124428 > Yes, the `JobContext` seems good to me! What do you think, @zjffdu? Sorry @TisonKun @aljoscha , to be honest, I would prefer to use `JobClient` directly and let user to take the risk if they accidentally close `JobClient` (We should highlight this in the javadoc of `JobListener`). The reason is that asking user to clean `JobClient` may be error-prone for users, e.g. I would allow user to cancel job later after submission in Zeppelin. So I have to keep JobClient in Zeppelin side, and call it somewhere else no only in method `onJobSumitted`, asking user to clean JobClient is extra burden for users and error-prone. I am afraid most of time they they will forget to clean it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
