wuchong commented on a change in pull request #10403: [FLINK-14645][table]
Support to keep nullability and precision when converting DataTypes to
properties
URL: https://github.com/apache/flink/pull/10403#discussion_r354396907
##########
File path: flink-python/pyflink/table/tests/test_descriptor.py
##########
@@ -825,27 +825,27 @@ def test_field_in_string(self):
properties = schema.to_properties()
expected = {'schema.0.name': 'int_field',
- 'schema.0.type': 'INT',
+ 'schema.0.data-type': 'INT',
'schema.1.name': 'long_field',
- 'schema.1.type': 'BIGINT',
+ 'schema.1.data-type': 'BIGINT',
'schema.2.name': 'string_field',
- 'schema.2.type': 'VARCHAR',
+ 'schema.2.data-type': 'VARCHAR(2147483647)',
Review comment:
STRING is an alias of `VARCHAR(2147483647)`, there is no `StringType`, so
the displaying is `VARCHAR(2147483647)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
