rkhachatryan commented on a change in pull request #10446: [FLINK-15076][task]
Fix SourceStreamTask cancellation
URL: https://github.com/apache/flink/pull/10446#discussion_r354420898
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTask.java
##########
@@ -131,8 +131,13 @@ protected void
processInput(MailboxDefaultAction.Controller controller) throws E
@Override
protected void cancelTask() {
- if (headOperator != null) {
- headOperator.cancel();
+ try {
+ if (headOperator != null) {
+ headOperator.cancel();
+ }
+ }
+ finally {
+ sourceThread.interrupt();
Review comment:
I'd restore that `sourceThread` interrupted status (just for clarity, if
someone later will modify it's catch statement).
Currently, it catches `Throwable`, completes future with it and exits.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
