klion26 commented on a change in pull request #10436: [FLINK-14920] [flink-end-to-end-perf-tests] Set up environment to run performance e2e tests URL: https://github.com/apache/flink/pull/10436#discussion_r354639614
########## File path: tools/jenkins/utils.py ########## @@ -0,0 +1,56 @@ +#!/usr/bin/env python +# -*- coding: utf-8 -*- +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################ + +import subprocess +import traceback +from logger import logger +from threading import Timer + + +def timeout_callback(p): + logger.warning('exe time out call back') + try: + p.kill() + except Exception as error: + logger.error(error) + + +def run_command(cmd, timeout=12000): + logger.info("cmd:%s" % cmd) + p = subprocess.Popen(cmd, shell=True, stdout=subprocess.PIPE, stderr=subprocess.STDOUT) + my_timer = Timer(timeout, timeout_callback, [p]) + my_timer.start() + lines = [] + try: + while True: + buff = p.stdout.readline() + line = buff.split("\n")[0] + logger.info(line) + if buff == "" and not p.poll() is None: + break + else: + lines.append(buff) + except Exception as e: + logger.error(traceback.format_exc()) + return 1, "", "" Review comment: can we replace `0/1` with `True/False` here for success or fail? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
