klion26 commented on a change in pull request #10449: [FLINK-7289][state-backend] Integrate RocksDB memory use with managed memory URL: https://github.com/apache/flink/pull/10449#discussion_r354662122
########## File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBSharedResources.java ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.contrib.streaming.state; + +import org.rocksdb.Cache; +import org.rocksdb.WriteBufferManager; + +/** + * The set of resources that can be shared by all RocksDB instances in a slot. + * Sharing these resources helps RocksDB a predictable resource footprint. + */ +final class RocksDBSharedResources implements AutoCloseable { + + private final Cache cache; + + private final WriteBufferManager writeBufferManager; + + RocksDBSharedResources(Cache cache, WriteBufferManager writeBufferManager) { + this.cache = cache; + this.writeBufferManager = writeBufferManager; + } + + public Cache getCache() { + return cache; + } + + public WriteBufferManager getWriteBufferManager() { + return writeBufferManager; + } + + @Override + public void close() throws Exception { Review comment: nit: `Exception` can be removed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
