caidezhi removed a comment on issue #10333: [FLINK-14970]Doomed test for 
equality to NaN
URL: https://github.com/apache/flink/pull/10333#issuecomment-562493939
 
 
   Hi @KurtYoung , i also aware of that.  Calcite uses BigDecimal for handling 
DOUBLE, FLOAT. when we pass unnormal numerical value((eg: INFINITY, NaN) 
literalType=DoubleType, literalValue=null are passed to method 
"GenerateUtils.generateLiteral",  the program will go to another branch, the 
pattern matching which has bug will not cause any impact.
   
   can we just remove the pattern matching logic to make it clean? if it is ok, 
i will make another commit for this PR. Thanks. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to