dianfu commented on a change in pull request #10430: [FLINK-14019][python][cli]
Add command-line options for managing Python UDF environment and dependencies.
URL: https://github.com/apache/flink/pull/10430#discussion_r354741388
##########
File path:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendRunTest.java
##########
@@ -126,6 +126,28 @@ public void testRun() throws Exception {
assertEquals("--arg2",
programOptions.getProgramArgs()[3]);
assertEquals("value2",
programOptions.getProgramArgs()[4]);
}
+
+ // test python arguments
+ {
+ String[] parameters =
+ {
+ "-py", "test.py", "-pyfs",
"test1.py,test2.zip,test3.egg,test4_dir", "-pyreq", "a.txt#b_dir",
+ "-pyarch", "c.zip#venv,d.zip",
"-pyexec", "bin/python"
+ };
+ CommandLine commandLine =
CliFrontendParser.parse(CliFrontendParser.RUN_OPTIONS, parameters, true);
+ ProgramOptions programOptions = new
ProgramOptions(commandLine);
+ assertEquals("--python",
programOptions.getProgramArgs()[0]);
+ assertEquals("test.py",
programOptions.getProgramArgs()[1]);
+ assertEquals("--pyFiles",
programOptions.getProgramArgs()[2]);
+ assertEquals("test1.py,test2.zip,test3.egg,test4_dir",
programOptions.getProgramArgs()[3]);
+ assertEquals("--pyRequirements",
programOptions.getProgramArgs()[4]);
+ assertEquals("a.txt#b_dir",
programOptions.getProgramArgs()[5]);
+ assertEquals("--pyArchives",
programOptions.getProgramArgs()[6]);
+ assertEquals("c.zip#venv,d.zip",
programOptions.getProgramArgs()[7]);
+ assertEquals("--pyExecutable",
programOptions.getProgramArgs()[8]);
+ assertEquals("bin/python",
programOptions.getProgramArgs()[9]);
+
Review comment:
remove this empty line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
