zentol commented on a change in pull request #10460: [FLINK-14574] Fixing writing with plugin s3 filesystem. URL: https://github.com/apache/flink/pull/10460#discussion_r354805691
########## File path: flink-end-to-end-tests/test-scripts/common_s3_minio.sh ########## @@ -22,11 +22,11 @@ export AWS_REGION=us-east-1 export AWS_ACCESS_KEY_ID=access_key export AWS_SECRET_ACCESS_KEY=secret_key -export IT_CASE_S3_BUCKET=test-data +IT_CASE_S3_BUCKET=test-data -export S3_TEST_DATA_WORDS_URI="s3://$IT_CASE_S3_BUCKET/words" - -export S3_OUTPUT_LOCATION="s3://$(basename "$TEST_DATA_DIR")/out/wc_out" +S3_TEST_DATA_WORDS_URI="s3://$IT_CASE_S3_BUCKET/words" +OUTPUT_PATH="$TEST_INFRA_DIR/$IT_CASE_S3_BUCKET/$OUT" Review comment: This script has no business deciding where data should be written to and should not write to TEST_INFRA_DIR in the first place but TEST_DATA_DIR as the latter is already scoped by test execution ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
