[
https://issues.apache.org/jira/browse/FLINK-15096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989780#comment-16989780
]
Wei Zhong commented on FLINK-15096:
-----------------------------------
[~dwysakowicz] , thanks for creating this JIRA. It will be great if we can find
a cleaner way. Just share my thoughts about the reason why we use the
GlobalJobParameter here.
We have thought about several solutions for this issues:
1) The current solution via GlobalJobParameter
2) Set the custom archives, files, executables to TableConfig and then
instantiating the operator with these configs (this seems the same solution as
you proposed?)
3) Set the custom archives, files, executables to the job configuration of
JobGraph
4) Register these configurations to DistributedCached under some predefined
name and then operators could retrieve these configurations
All the above solutions have some problems:
1) Regarding to solution 1, just as you mentioned, GlobalJobParameter is a
user oriented configuration.
2) Regarding to solution 2, TableConfig seems also not a good place to hold
the custom archives, files, executables as it exposes these internal
configurations to users.
3) Regarding to solution 3, we need to expose job configuration in JobGraph,
it seems also not acceptable.
4) Regarding to solution 4, it seems too hack for me.
The first solution seems more acceptable as it will not introduce any API
changes. What's your thoughts? It will be great if we can find a cleaner way.
> Do not use GlobalJobParameters to pass system configuration
> -----------------------------------------------------------
>
> Key: FLINK-15096
> URL: https://issues.apache.org/jira/browse/FLINK-15096
> Project: Flink
> Issue Type: Bug
> Components: API / Python
> Affects Versions: 1.10.0
> Reporter: Dawid Wysakowicz
> Priority: Major
> Fix For: 1.10.0
>
>
> GlobalJobParameters is a user only configuration that should not be used to
> ship system specific settings.
> Right now python uses it to ship information about custom archives, files,
> executables etc.
> A solution would be to pass required configuration when instantiating the
> operators.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
