[
https://issues.apache.org/jira/browse/FLINK-15096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989790#comment-16989790
]
Dawid Wysakowicz edited comment on FLINK-15096 at 12/6/19 2:09 PM:
-------------------------------------------------------------------
Yes my suggested solution is somewhat similar to the option 2. The difference
is I am not suggesting to add new fields/methods to TableConfig. From the API
side it would be exactly the same as it is in the current master.
The difference is how you access it in the Operator. I am suggesting to access
the settings from {{TableConfig#getConfiguration()}} as you said when
instantiating the operator.
In https://github.com/apache/flink/pull/10431 I would like only the map stored
under {{pipeline.global-job-parameters}} in {{TableConfig#getConfiguration}} to
be shipped to {{GlobalJobParameters}}.
was (Author: dawidwys):
Yes my suggested solution is somewhat similar to the option 2. The difference
is I am not suggesting to add new fields/methods to TableConfig. From the API
side it would be exactly the same as it is in the current master.
The difference is how you access it in the Operator. I am suggesting to access
the settings from {{TableConfig#getConfiguration()}} as you said when
instantiating the operator.
After https://github.com/apache/flink/pull/10431 only the map stored under
{{pipeline.global-job-parameters}} in {{TableConfig#getConfiguration}} will be
shipped to {{GlobalJobParameters}}.
> Do not use GlobalJobParameters to pass system configuration
> -----------------------------------------------------------
>
> Key: FLINK-15096
> URL: https://issues.apache.org/jira/browse/FLINK-15096
> Project: Flink
> Issue Type: Bug
> Components: API / Python
> Affects Versions: 1.10.0
> Reporter: Dawid Wysakowicz
> Priority: Major
> Fix For: 1.10.0
>
>
> GlobalJobParameters is a user only configuration that should not be used to
> ship system specific settings.
> Right now python uses it to ship information about custom archives, files,
> executables etc.
> A solution would be to pass required configuration when instantiating the
> operators.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
