aljoscha opened a new pull request #10474: [FLINK-15116] Make JobClient 
stateless, remove AutoCloseable
URL: https://github.com/apache/flink/pull/10474
 
 
   ## What is the purpose of the change
   
   *Right now this is a proposal to show others what it looks like. If we agree 
on this changed behaviour I should add tests for it. Currently we don't have 
tests for `JobClient`, though.*
   
   With this change, the JobClient acquires the required ClusterClient for
   each method call. This means that the users no longer have the burden of
   managing the JobClient lifecycle, i.e. they can freely ignore the result
   of executeAsync().
   
   I also modified the `SocketWindowWordCount` to play around and show how the 
API works. **(This will be reverted)**.
   
   ## Brief change log
   
     - The first commit changes `ClusterDescriptor` to return a 
`ClusterClientProvider` so that consumers of the method can create a new 
`ClusterClient` whenever needed
     - The second commit changes `JobClient` to create a new `ClusterClient` 
from the provider for every method call. It therefore does not need to hold any 
resources that need to be cleaned up
   
   ## Verifying this change
   
   Same test coverage as before, we don't test the `JobClient` yet.
   
   ## Documentation
   
     - `JobClient` is not yet documented and this PR also doesn't add any 
documentation.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to