JingsongLi commented on a change in pull request #10452:
[FLINK-15035][table-planner-blink] Introduce unknown memory setting to table in
blink planner
URL: https://github.com/apache/flink/pull/10452#discussion_r355107104
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/join/SortMergeJoinOperator.java
##########
@@ -64,7 +64,8 @@
public class SortMergeJoinOperator extends TableStreamOperator<BaseRow>
implements TwoInputStreamOperator<BaseRow, BaseRow, BaseRow>,
BoundedMultiInput {
- private final long externalBufferMemory;
+ private final double externalBufferMemRatio;
+ private final long maxExternalBufferMemory;
Review comment:
If you think there's code complexity, and you insist, I can remove the
biggest limitation. It's just an optimization. We can waste some memory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
