zhuzhurk commented on a change in pull request #10462: [FLINK-15031][runtime]
Calculate required shuffle memory before allocating slots if resources are
specified
URL: https://github.com/apache/flink/pull/10462#discussion_r355110152
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/NettyShuffleMaster.java
##########
@@ -28,8 +30,15 @@
/**
* Default {@link ShuffleMaster} for netty and local file based shuffle
implementation.
*/
-public enum NettyShuffleMaster implements
ShuffleMaster<NettyShuffleDescriptor> {
- INSTANCE;
+public class NettyShuffleMaster implements
ShuffleMaster<NettyShuffleDescriptor> {
+
+ @VisibleForTesting
+ public NettyShuffleMaster() {
+ this(new Configuration());
+ }
Review comment:
Agreed. Will introduce a `ShuffleTestUtils#DEFAULT_SHUFFLE_MASTER` for this
purpose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
