zentol commented on issue #10466: [FLINK-15110][metrics] Support variable exclusion URL: https://github.com/apache/flink/pull/10466#issuecomment-562844641 @Myasuka > I agreed that this PR is a solution to solve problems like FLINK-13418. This is not intended to be a solution for FLINK-13418. > Only system variables in defined system scopes would be emitted, and user variables are not limited with these scopes. Implicitly deriving the tags to expose from the configured scope format breaks every existing setup of tag-based reporters. It is also conceptually unsound as there are plenty of variables that exist outside the system scope which should be controllable as well. Additionally it is not a solution for the cardinality explosion, which either requires a general exclusion (provided here) or a flag per variable for whether it should be indexed or not. This can be explored in the future as pointed out in the JIRA ticket for FLINK-15110. > there is no explicit concept of tag for Flink metrics For all intents and purposes variables are equivalent to tags. Conceptually, what you are suggesting is an include list per scope level; and this is certainly something one could look into in the future. Nevertheless, being able to globally discard unwanted tags is still a useful feature that I could implement before the feature freeze without API changes, in contrast to every other approach.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
